Fixed use of "window" instead of "global". #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Swindell <[email protected]>
dignifiedquire
requested changes
Jan 14, 2017
| @@ -19,7 +19,7 @@ module.exports = function webcryptoShim (global) { | |||
| _SubtleCrypto = global.SubtleCrypto || _subtle.constructor || Object, | |||
| _CryptoKey = global.CryptoKey || global.Key || Object; | |||
|
|
|||
| var isEdge = window.navigator.userAgent.indexOf('Edge/') > -1 | |||
| var isEdge = global.navigator.userAgent.indexOf('Edge/') > -1 | |||
There was a problem hiding this comment.
I don't think global is defined in all browsers, maybe check for not being undefined in this order
- global
- window
- self
There was a problem hiding this comment.
global is a local variable, it is the variable that is assigned to window or self.
There was a problem hiding this comment.
I should read the code I'm reviewing more closely :/
|
Thank you |
dignifiedquire
approved these changes
Jan 14, 2017
|
Is this closed now then? ;) |
|
latest libp2p-crypto includes this and runs tests in webworkers so should work all good now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Swindell [email protected]