This repository has been archived by the owner on Oct 20, 2020. It is now read-only.
Reinstate function that was erroneously removed #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the issue with our local tests, just tried it. |
|
Nice catch, not sure how it happened. LGTM |
|
Released as 0.1.1 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here we lost a function that we needed: 12bfbdf#diff-fd1f6b9cc2a83b11b2e67dcdd20c6a77L82
We noticed on Friday that some tests using
xgboostwere now failing locally. Usedgit bisectto track it to a commitUse latest master of rules_python_external, that lets you set a longer timeout on pypi fetching (#4261).cc @groodt