fix #414: use the statusCode and headers fields from the response.body instead of the response. #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…response.body instead of the response. This makes the production build behave the same to the dev version (https://github.com/dillonkearns/elm-pages/blob/57dccef4334e264659af53465de786028e9566d9/generator/src/dev-server.js#L550-L553) Note that statusCode also exists on the `response`, but is hard-coded to be 200 on the Elm side.
👷 Deploy request for elm-pages-todos pending review.Visit the deploys page to approve it
|
yoshi-monster
changed the title
|
Thank you so much for the PR @jreusch4! And thank you @adamdicarlo0 for reporting as well. This will go out with the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the production build behave the same to the dev version here:
elm-pages/generator/src/dev-server.js
Lines 550 to 553 in 57dccef
I would have liked to add some tests for this as well, but I could not find an existing place similar enough to add them to, and I didn't want to go ahead and just add end-to-end testing stuff that you might not want :)