Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lunr): some optimizing lib/lunr/*.js #367

Merged
merged 26 commits into from
May 18, 2020
Merged

feat(lunr): some optimizing lib/lunr/*.js #367

merged 26 commits into from
May 18, 2020

Conversation

dogukanerel
Copy link
Contributor

Hi, I found unnecessary semicolon in some js file. If you want you can accept this pr.

@@ -2,7 +2,7 @@
* export the module via AMD, CommonJS or as a browser global
* Export code from https://github.com/umdjs/umd/blob/master/returnExports.js
*/
;(function (root, factory) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary semicolon!

@@ -22,7 +22,7 @@
* export the module via AMD, CommonJS or as a browser global
* Export code from https://github.com/umdjs/umd/blob/master/returnExports.js
*/
;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary semicolon!

@@ -19,7 +19,7 @@
* export the module via AMD, CommonJS or as a browser global
* Export code from https://github.com/umdjs/umd/blob/master/returnExports.js
*/
;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary semicolon!

@@ -19,7 +19,7 @@
* export the module via AMD, CommonJS or as a browser global
* Export code from https://github.com/umdjs/umd/blob/master/returnExports.js
*/
;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary semicolon!

@@ -19,7 +19,7 @@
* export the module via AMD, CommonJS or as a browser global
* Export code from https://github.com/umdjs/umd/blob/master/returnExports.js
*/
;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary semicolon!

@@ -19,7 +19,7 @@
* export the module via AMD, CommonJS or as a browser global
* Export code from https://github.com/umdjs/umd/blob/master/returnExports.js
*/
;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary semicolon!

assets/lib/lunr/lunr.fr.js Show resolved Hide resolved
@@ -19,7 +19,7 @@
* export the module via AMD, CommonJS or as a browser global
* Export code from https://github.com/umdjs/umd/blob/master/returnExports.js
*/
;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary semicolon!

@dillonzq dillonzq changed the base branch from master to develop May 18, 2020 09:31
@dillonzq dillonzq changed the title Some optimizing lib/lunr/*.js feat(lunr): some optimizing lib/lunr/*.js May 18, 2020
@dillonzq dillonzq added the enhancement New feature or request label May 18, 2020
@dillonzq dillonzq merged commit c1016df into dillonzq:develop May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants