Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all test files in sdist #237

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Include all test files in sdist #237

merged 1 commit into from
Feb 25, 2025

Conversation

millerdev
Copy link
Contributor

@millerdev millerdev commented Feb 25, 2025

Fixes error due to no tests found while building and publishing to PyPI. This change was intended to be part of #236. Prior to this, the test files in the source distribution were incomplete.

Sample failure:

       + sh -c 'cd /project; python -m unittest'
  ----------------------------------------------------------------------
  Ran 0 tests in 0.000s
  NO TESTS RAN
                                                              ✕ 3.16s
Error: Command ['sh', '-c', 'cd /project; python -m unittest'] failed with code 5. 
Error: Process completed with exit code 1.

I missed this MANIFEST.in change when I was renaming tests.yml back to pypi.yml after I had completed testing the action. See testing process in the description of #236 for more details on how that was done.

@millerdev millerdev requested a review from gherceg February 25, 2025 17:31
@millerdev millerdev marked this pull request as ready for review February 25, 2025 17:31
@millerdev
Copy link
Contributor Author

millerdev commented Feb 25, 2025

It is possible to use Workflow Dispatch to run the Build wheels and publish to PyPI action on this branch now that pypi.yml is on the master branch.

It works now - evidence on PyPI

@millerdev millerdev merged commit d9797ba into master Feb 25, 2025
12 checks passed
@millerdev millerdev deleted the dm/fix-pypi-action branch February 25, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants