Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use enum variants rather than casting to u8 for comparisons #781

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use enum variants rather than casting to u8 for comparisons #781

wants to merge 1 commit into from

Conversation

Vrixyz
Copy link
Contributor

@Vrixyz Vrixyz commented Jan 7, 2025

Vrixyz
Vrixyz commented Jan 7, 2025
View reviewed changes
src/dynamics/coefficient_combine_rule.rs
@@ -7,29 +7,34 @@ use crate::math::Real;
/// Each collider has its combination rule of type
/// `CoefficientCombineRule`. And the rule
/// actually used is given by `max(first_combine_rule as usize, second_combine_rule as usize)`.
#[derive(Default, Copy, Clone, Debug, PartialEq, Eq)]
#[derive(Default, Copy, Clone, Debug, PartialEq, Eq, PartialOrd, Ord)]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a changelog line ?

@Vrixyz Vrixyz requested a review from sebcrozet January 10, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebcrozet sebcrozet Awaiting requested review from sebcrozet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Vrixyz