Lazy initialize singleton mixer node #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch |
dimitris-c
approved these changes
Aug 14, 2023
Comment on lines
+159
to
+161
| frameFilterProcessor = FrameFilterProcessor(mixerNodeProvider: { | ||
| engine.mainMixerNode | ||
| }) |
There was a problem hiding this comment.
It could also be possible that the frameFilterProcessor be initialised when a relevant method is first used. But we could improve on another PR.
|
I won't be able to make a release since I'm on annual leave. Do you mind creating one? I think you just need to bump versions 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue 49. According to apple, the
mainMixerNodesingleton has an side effect on first access. This is whyAudioPlayerinitializer will stop existing background audio. The fix defer the access by making it inside a lazy var.