Will not work for Indonesian translation

[taai]

It wont work simply because the Indonesian language code is id.

[dimsav]

I don't see why this causes a problem. What is the error message you get?

Please provide more info.

[taai]

@dimsav I didn't even test it. Code is very readable, so I red it. 😉
Here is an example of getting Indonesian translation:

<?php
$country = Country::where('iso', '=', 'id')->first();
echo $country->id->name; // Will throw an error (probably)

I believe that the error will be about that I'm trying to get name attribute from non-object. That, or it will return the translation, but wont be able to get the id number of the Country model. I don't know.

[dimsav]

Ok, I will check this after the end of my holidays in 10 days.

[dimsav]

In the meantime use "ind" as iso.

[taai]

@dimsav I have never made an app with Indonesian language in use. I'm just saying that this is a potential problem.
Because of this potential problem everybody should better use the getTranslation() method instead of fetching language-like attributes.

$country = Country::where('iso', '=', 'gr')->first();
echo $country->getTranslation('en')->name; // Greece

App::setLocale('en');
echo $country->name;     // Greece

App::setLocale('de');
echo $country->name;     // Griechenland

For Indonesian id locale this won't work anyway, because your code calls getAttribute() which will try to get id... You should use $this->relations[$locale] to access the translation models.

I know that using $mondel->getTranslation('en') is little less handy than using $model->en, but on the other side - it is more understandable.

Probably you it's ok to keep also $model->en option, but I recommend not to promote it as the best way to do this.

[sdebacker]

I agree with taai.

[dimsav]

Alright, so I will update the documentation in the readme file and promote getTranslation() instead of $country->en->name. I wonder if it would be a good idea to deprecate it in a future version.

Update: The syntax $country->en->name has to be and will be deprecated in the future version. id is the most frequent iso code, nevertheless, the same will happen in the model (country) has another attributed using the same name with a used iso code.

Thanks for the notice!

[dimsav]

The changes were just released with the new version 4.0.0. I also created a method translate() alias of getTranslation() to make things more readable. Read the readme and let me know if you disagree on something.

@taai and @sdebacker thanks for your feedback!