Skip to content

Commit

Permalink
UPSTREAM: ASoC: SOF: Intel: disable IMR boot when resuming from ACPI …
Browse files Browse the repository at this point in the history
…S4 and S5 states

The IMR was assumed to be preserved when suspending to S4 and S5
states, but community reports invalidate that assumption, the hardware
seems to be powered off and the IMR memory content cleared.

Make sure regular boot with firmware download is used for S4 and S5.

BugLink: thesofproject/sof#5892
Fixes: 5fb5f51185126 ("ASoC: SOF: Intel: hda-loader: add IMR restore support")
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
Reviewed-by: Péter Ujfalusi <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
(cherry picked from commit 391153522d186f19a008d824bb3a05950351ce6c)

BUG=b:238403794
TEST=Test Audio use cases.

Change-Id: I1fdef780cc69ee3eedf5819e8b6bfcf5f14c9596
Signed-off-by: Rutumber Nath <[email protected]>
  • Loading branch information
plbossart authored and aketi-subbu committed Feb 8, 2023
1 parent 5234d55 commit 7d3e211
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion sound/soc/sof/intel/hda-loader.c
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,8 @@ int hda_dsp_cl_boot_firmware(struct snd_sof_dev *sdev)
struct snd_dma_buffer dmab;
int ret, ret1, i;

if (hda->imrboot_supported && !sdev->first_boot) {
if (sdev->system_suspend_target < SOF_SUSPEND_S4 &&
hda->imrboot_supported && !sdev->first_boot) {
dev_dbg(sdev->dev, "IMR restore supported, booting from IMR directly\n");
hda->boot_iteration = 0;
ret = hda_dsp_boot_imr(sdev);
Expand Down

0 comments on commit 7d3e211

Please sign in to comment.