Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

problem/solution returning user certificate #288

Closed
celane opened this issue Feb 11, 2018 · 1 comment · Fixed by #301
Closed

problem/solution returning user certificate #288

celane opened this issue Feb 11, 2018 · 1 comment · Fixed by #301

Comments

@celane
Copy link

celane commented Feb 11, 2018

Claws-mail failed SSL handshake when a 'user certificate' was made available (claws-mail 3.15.1, libetpan 1.7.2, gnutls 3.5.16, fedora 26). Tracing the error messages (and using gdb) showed that a callback to mailstream_gnutls_client_cert_cb was not setting "cert_type", and incorrectly setting "key_type".

This looks like a problem from the change of gnutls 3.0 api. A small patch to fix this is attached; tested with claws-mail and it works for a .pem user certificate/private key.

Note that gnutls_certificate_type_get is used to get the "cert_type", but there doesn't seem to be a similar call for getting the key_type, and the type is hidden inside an internal struct. So just set the key_type to X509, since that's the type that is being imported.
libetpan-CEL-20180211.patch.txt
@dinhvh
Copy link
Owner

dinhvh commented Jun 4, 2018

Could you create a pull request for libetpan? Thanks!

ncopa added a commit to ncopa/libetpan that referenced this issue Aug 27, 2018
@ncopa
Fix user certificate with gnutls 3.0 api
98ecc14 
fixes dinhvh#288
@ncopa ncopa mentioned this issue Aug 27, 2018
Merged
algitbot pushed a commit to alpinelinux/aports that referenced this issue Aug 27, 2018
@ncopa
main/libetpan: fix user cert
173054f 
ref #9340

upstream report: dinhvh/libetpan#288
algitbot pushed a commit to alpinelinux/aports that referenced this issue Aug 27, 2018
@ncopa
main/libetpan: fix user cert
f188e4a 
fixes #9340

upstream report: dinhvh/libetpan#288

(cherry picked from commit 173054f)
neechbear pushed a commit to neechbear/aports that referenced this issue Sep 9, 2018
@ncopa @neechbear
main/libetpan: fix user cert
e135bb2 
ref alpinelinux#9340

upstream report: dinhvh/libetpan#288
dinhvh pushed a commit that referenced this issue Sep 11, 2018
@ncopa @dinhvh
Fix user certificate with gnutls 3.0 api (#301)
47682f3 
fixes #288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix user certificate with gnutls 3.0 api ncopa/libetpan
2 participants
@dinhvh @celane