-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add natspec #65
Merged
Merged
Add natspec #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zodahu
force-pushed
the
feature/complete_comments
branch
from
May 5, 2023 09:51
f80d999
to
e0d8e74
Compare
hihiben
reviewed
May 9, 2023
MussinaLin
reviewed
May 9, 2023
MussinaLin
reviewed
May 9, 2023
MussinaLin
reviewed
May 9, 2023
zodahu
force-pushed
the
feature/complete_comments
branch
from
May 9, 2023 08:32
e0d8e74
to
ef23c9e
Compare
hihiben
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Natspec comments have been added to most
/src
contracts, except for/src/fees
, as they may be updated recently. For instance, not all functions inFeeVerifier
have been provided with Natspec comments.MakerUtility
openLockETHAndDraw
,AaveV2FlashLoanCallback
executeOperation
, they don't include the @param Natspec comments, as they are already defined and documented within their respective protocols.