Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xc/Initial commit for ZMP Biped Robot #269

Merged
merged 52 commits into from
Aug 2, 2023

Conversation

7380Xing
Copy link
Contributor

First commit for the ZMP Biped Robot

@JulienCalbert
Copy link
Collaborator

Hello Xing, thank you for this.
It's a very good version of the code that seems clear at first glance. Of course we'll have to think about the organization into folders, ... But I think that once the following changes have been made, we'll be able to merge and already have a first version saved on Dionysos.
Before we merge, could you look at the following points?

Copy link
Collaborator

@egidioln egidioln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @7380Xing! Unfortunately I cannot review in detail all files but I think it is a clean well documented work !

BipedRobot/ZMPBipedRobot/README.md Outdated Show resolved Hide resolved
BipedRobot/ZMPBipedRobot/README.md Outdated Show resolved Hide resolved
BipedRobot/ZMPBipedRobot/README.md Outdated Show resolved Hide resolved
BipedRobot/ZMPBipedRobot/README.md Outdated Show resolved Hide resolved
BipedRobot/ZMPBipedRobot/ZMP_based_controller.png Outdated Show resolved Hide resolved
7380Xing and others added 27 commits July 18, 2023 11:17
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023

Codecov Report

Merging #269 (d5bfe2f) into master (8d2e04b) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #269   +/-   ##
=======================================
  Coverage   79.82%   79.82%           
=======================================
  Files          62       62           
  Lines        4361     4361           
=======================================
  Hits         3481     3481           
  Misses        880      880           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@7380Xing
Copy link
Contributor Author

7380Xing commented Aug 1, 2023

@adrienbanse @JulienCalbert I have made my last commit normally you can pull the code.
However, I didn't manage to format again the code correctly. So, the lastest version of the code have some part which isn't formated yet.

@adrienbanse
Copy link
Collaborator

@adrienbanse @JulienCalbert I have made my last commit normally you can pull the code. However, I didn't manage to format again the code correctly. So, the lastest version of the code have some part which isn't formated yet.

Thanks a lot @7380Xing, can you give me the commit/changes permissions on your fork https://github.com/7380Xing/Dionysos.jl/tree/master ? I'll clone it on my computer and try it myself
I saw there is a also a problem with the documentation @JulienCalbert, to be fixed

@JulienCalbert
Copy link
Collaborator

Ok great, I will go through the code tomorrow and create an issue with the points we discussed this morning. But we will look at it on our side with Adrien. Many thanks and great job!

@7380Xing
Copy link
Contributor Author

7380Xing commented Aug 1, 2023

Thanks as well. I have added Adrien and Julien as colaborators in the Git Repository, normally you should get an invit

@adrienbanse adrienbanse merged commit 473b8e3 into dionysos-dev:master Aug 2, 2023
@adrienbanse adrienbanse mentioned this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants