-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xc/Initial commit for ZMP Biped Robot #269
Conversation
Hello Xing, thank you for this.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @7380Xing! Unfortunately I cannot review in detail all files but I think it is a clean well documented work !
BipedRobot/ZMPBipedRobot/examples/1. Default Controller/default_controller.jl
Outdated
Show resolved
Hide resolved
BipedRobot/ZMPBipedRobot/examples/1. Default Controller/default_controller.jl
Outdated
Show resolved
Hide resolved
BipedRobot/ZMPBipedRobot/examples/1. Default Controller/results/CoM_trajectory.png
Outdated
Show resolved
Hide resolved
BipedRobot/ZMPBipedRobot/examples/2. Optimisation process/results/sim_objectives.png
Outdated
Show resolved
Hide resolved
BipedRobot/ZMPBipedRobot/examples/2. Optimisation process/results/solutions.txt
Outdated
Show resolved
Hide resolved
Co-authored-by: Lucas Egidio <[email protected]>
Co-authored-by: Lucas Egidio <[email protected]>
Co-authored-by: Lucas Egidio <[email protected]>
Co-authored-by: Lucas Egidio <[email protected]>
…t_controller.jl Co-authored-by: Lucas Egidio <[email protected]>
…t_controller.jl Co-authored-by: Lucas Egidio <[email protected]>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #269 +/- ##
=======================================
Coverage 79.82% 79.82%
=======================================
Files 62 62
Lines 4361 4361
=======================================
Hits 3481 3481
Misses 880 880 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@adrienbanse @JulienCalbert I have made my last commit normally you can pull the code. |
Thanks a lot @7380Xing, can you give me the commit/changes permissions on your fork https://github.com/7380Xing/Dionysos.jl/tree/master ? I'll clone it on my computer and try it myself |
Ok great, I will go through the code tomorrow and create an issue with the points we discussed this morning. But we will look at it on our side with Adrien. Many thanks and great job! |
Thanks as well. I have added Adrien and Julien as colaborators in the Git Repository, normally you should get an invit |
First commit for the ZMP Biped Robot