Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fetching repos file from URL #155

Merged
merged 11 commits into from
Jul 1, 2020

Conversation

christophebedard
Copy link
Contributor

Supersedes and addresses review feedback from #123

I added a simple test, but the actual request could probably easily be mocked (#103).

Copy link
Owner

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up. Please see a few comments / questions inline.

vcstool/commands/import_.py Outdated Show resolved Hide resolved
vcstool/commands/import_.py Outdated Show resolved Hide resolved
vcstool/commands/import_.py Outdated Show resolved Hide resolved
@dirk-thomas
Copy link
Owner

dirk-thomas commented Jul 1, 2020

Thanks for the updates. I made two minor changes:

  • moved the new function around, condensed the lines a bit and renamed the function argument from x to value and
  • reverted the unrelated default value change (I will create a separate PR for that which addresses the same in another place too)

@dirk-thomas dirk-thomas added this to the 0.2.13 milestone Jul 1, 2020
@christophebedard
Copy link
Contributor Author

looks good!

@dirk-thomas dirk-thomas merged commit 0044ece into dirk-thomas:master Jul 1, 2020
@christophebedard christophebedard deleted the fetch-repos-from-url branch July 1, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants