Skip to content
This repository has been archived by the owner on Feb 18, 2025. It is now read-only.

migrate winapi to windows-rs #16

Closed
wants to merge 2 commits into from
Closed

migrate winapi to windows-rs #16

wants to merge 2 commits into from

Conversation

atamakahere-git
Copy link

This PR migrates winapi-rs to windows-rs. windows-rs is the bindings crate provided by Microsoft, and is actively maintained compared to winapi-rs.

@soc
Copy link
Collaborator

soc commented Feb 3, 2023

@tanveerraza789 Thanks for dropping the reformat. ;-)

Do you know what's the version requirement of this windows crate, its impact on size and whether it runs without std?

@atamakahere-git
Copy link
Author

atamakahere-git commented Feb 3, 2023

Performance wise, using windows-rs make compilation slower, check this PR on rust-lang
We also has windows-sys with zero-overhead. Check out this branch which uses windows-sys instead.

Minimum version requirement for this code to compile is windows 0.41.0 or windows-sys 0.36.1

@soc soc closed this in 044360b Mar 3, 2023
@soc
Copy link
Collaborator

soc commented Mar 3, 2023

I squashed and merged your changes, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants