Require handlers to return *Response directly #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the generated handler methods inside ServerInterface
to directly return a *Response value instead of requiring it to call
render.Render
manually. This results in much cleaner handler code.While this change breaks all existing code, it is not a significant
change by any means, so most changes can be regexed away to work.
As an example,
petstore
'sFindPetByID
is nowcompared to before
Ideally, the above piece of code would look something like
where a
FindPetByIDJSON404Response
is properly generated by the OpenAPI schema having the 404 status code documented, but it isn't in the example schema for some reason.