Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make status code public in generated code #86

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

karitham
Copy link
Collaborator

Fixes #84

@diamondburned
Copy link
Contributor

I think we should also just export the other 2 fields while we're at it. Maybe even support io.ReadCloser for the Body.

@karitham
Copy link
Collaborator Author

Sourcing discord #goapi-gen for reference:

I feel like contentType should stay private, since it's kind of subject to change, and we might just add other headers / change how they behave
also, having the body as interface is kind of required since we have response to implement render, and thus the stuff can be marshalled as XML/YAML/JSON/whatever

@karitham karitham merged commit d0dd154 into discord-gophers:main Mar 29, 2022
@karitham karitham deleted the feat/expose-status-code branch March 29, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: ResponseCode
3 participants