refactor: middleware #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolheiser
reviewed
Apr 5, 2022
jolheiser
reviewed
Apr 5, 2022
Change for REST API consumer: close to none (now doesn't return 500 in case of multiple errors) Change for dev: Slight function signature change BREAKING: Middleware function signature have changed (as well as their names) FIX: fixes unknown errors due to multierror
karitham
force-pushed
the
refactor/middleware
branch
from
3d40656 to
b0a4e0e
Compare
jolheiser
reviewed
Apr 5, 2022
Co-authored-by: John Olheiser <[email protected]>
jolheiser
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the middleware package in such a way that promotes non-breaking changes later on, thus, we could now easily support #79 (presented we actually want that and get to it)
It is also slightly safer, since users can't change the options at runtime, which could have been a tiny issue if it ever happened
Change for REST API consumer: close to none (now doesn't return 500 in
case of multiple errors)
Change for dev: Slight function signature change
BREAKING: Middleware function signature have changed (as well as their
names)
FIX: fixes unknown errors due to multierror