Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top-level components are not necessarily action rows #7115

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

advaith1
Copy link
Contributor

@advaith1 advaith1 commented Aug 30, 2024

looks like people were writing code that assumes that top-level components are always action rows, but that is not the case. unfortunately we were saying this in the docs, so removing that

@advaith1 advaith1 requested a review from a team as a code owner August 30, 2024 20:40
@advaith1 advaith1 requested review from shaydewael and removed request for a team August 30, 2024 20:40
@ManHatos
Copy link
Contributor

When are they not action rows?

@advaith1
Copy link
Contributor Author

currently all components bots can send need to be in action rows. however the new content inventory component (from the new activity cards feature) is not in an action row, and future display components for bot UIs will not use action rows.

@Rapptz
Copy link
Contributor

Rapptz commented Aug 30, 2024

This is a breaking change risk for a few libraries, including discord.py (for sending, not receiving). I'm mentioning it here instead of Discord just so there's a paper trail for the statement. Whether the change is for the receiving end, the sending end, or both varies but either way this change can break things.

@Bilal2453
Copy link

A bit less important library here, but this also completely breaks sending this component in my library, which pretty much hardcodes the action row requirement in the logic. On the receiving end it was annoying enough I provide an almost raw structure to the user, but most of my users also assume an action row always exists, completely breaking their code.

@JustinBeckwith JustinBeckwith merged commit 745e014 into main Sep 4, 2024
4 checks passed
@JustinBeckwith JustinBeckwith deleted the top-level-components branch September 4, 2024 16:44
Snazzah added a commit to Snazzah/slash-create that referenced this pull request Sep 6, 2024
@bsian03 bsian03 mentioned this pull request Oct 20, 2024
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants