Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note placeholder ID return type in guild template's serialized_source_guild #7232

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Note placeholder ID return type in guild template's serialized_source_guild #7232

merged 1 commit into from
Oct 25, 2024

Conversation

azycheng
Copy link
Contributor

Placeholder IDs in serialized_source_guild (system_channel_id, afk_channel_id, and other channel ids) are given as integers -- not as strings.

@azycheng azycheng requested a review from appellation October 25, 2024 02:15
@azycheng azycheng requested a review from a team as a code owner October 25, 2024 02:15
@azycheng azycheng requested review from colinloretz and removed request for a team October 25, 2024 02:15
@bsian03 bsian03 mentioned this pull request Oct 25, 2024
Open
55 tasks
@JustinBeckwith JustinBeckwith merged commit 5729ea4 into main Oct 25, 2024
4 checks passed
@JustinBeckwith JustinBeckwith deleted the guild-template-placeholder-ints branch October 25, 2024 15:10
@azycheng
Copy link
Contributor Author

Addresses #6609

@Fleny113 Fleny113 mentioned this pull request Oct 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appellation appellation appellation approved these changes

@colinloretz colinloretz Awaiting requested review from colinloretz colinloretz is a code owner automatically assigned from discord/devrel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azycheng @appellation @JustinBeckwith