voice: reimplement seek option (#2572)

discordjs · Jun 13, 2018 · 1cdee7b · 1cdee7b
1 parent 04618f5
commit 1cdee7b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/client/voice/player/BasePlayer.js b/src/client/voice/player/BasePlayer.js
@@ -44,7 +44,10 @@ class BasePlayer extends EventEmitter {
     this.destroyDispatcher();
 
     const isStream = input instanceof ReadableStream;
+
     const args = isStream ? FFMPEG_ARGUMENTS : ['-i', input, ...FFMPEG_ARGUMENTS];
+    if (options.seek) args.push('-ss', String(options.seek));
+
     const ffmpeg = new prism.FFmpeg({ args });
     const streams = { ffmpeg };
     if (isStream) {

diff --git a/src/client/voice/util/PlayInterface.js b/src/client/voice/util/PlayInterface.js
@@ -6,7 +6,7 @@ const { Error } = require('../../../errors');
  * Options that can be passed to stream-playing methods:
  * @typedef {Object} StreamOptions
  * @property {StreamType} [type='unknown'] The type of stream.
- * @property {number} [seek=0] The time to seek to
+ * @property {number} [seek=0] The time to seek to, will be ignored when playing `ogg/opus` or `webm/opus` streams
  * @property {number|boolean} [volume=1] The volume to play at. Set this to false to disable volume transforms for
  * this stream to improve performance.
  * @property {number} [passes=1] How many times to send the voice packet to reduce packet loss