fix/feat(MessageEmbed): deep copy fields and fix files when passed in…

…to constructor (#1864)
discordjs · Sep 9, 2017 · 63f6247 · 63f6247
1 parent c523e22
commit 63f6247
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/structures/MessageEmbed.js b/src/structures/MessageEmbed.js
@@ -54,7 +54,7 @@ class MessageEmbed {
      * @property {string} value The value of this field
      * @property {boolean} inline If this field will be displayed inline
      */
-    this.fields = data.fields || [];
+    this.fields = data.fields ? data.fields.map(Util.cloneObject) : [];
 
     /**
      * The thumbnail of this embed (if there is one)
@@ -138,8 +138,13 @@ class MessageEmbed {
      * @property {Array<FileOptions|string|MessageAttachment>} files Files to attach
      */
     if (data.files) {
-      for (let file of data.files) if (file instanceof MessageAttachment) file = file.file;
-    } else { data.files = null; }
+      this.files = data.files.map(file => {
+        if (file instanceof MessageAttachment) {
+          return typeof file.file === 'string' ? file.file : Util.cloneObject(file.file);
+        }
+        return file;
+      });
+    }
   }
 
   /**