types: remove newMessage partial on messageUpdate event typing #10526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
Since this pr updates the message related event types, I think we can go ahead and also refactor it to omit PartialGroupDMChannel (as it is for it's sister counterparts) using |
|
You're right, not sure how I missed that, thanks! |
Jiralite
approved these changes
Oct 1, 2024
|
Rebased with master. |
benjGam
approved these changes
Oct 5, 2024
vladfrangu
approved these changes
Oct 6, 2024
didinele
approved these changes
Oct 6, 2024
Jiralite
pushed a commit
that referenced
this pull request
Oct 9, 2024
* types: remove newMessage partial on messageUpdate event typing * types: omit partial group DM for newMessage on messageUpdate * types: omit partial group DM for oldMessage on messageUpdate --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
According to discord/discord-api-docs#7017 the message update payload is no longer a partial object, but rather the full message object. As such, the ClientEvents#messageUpdate's
newMessageshouldn't be typed as a partial anymore, which is what this PR modifies.It also applies the
OmitPartialGroupDMChannelgeneric to both messages, since this event won't be triggered from group DMs.Closes #10525.
Status and versioning classification: