Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Deprecate reason parameter on adding and removing thread members #10551

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Deprecates the reason parameter on adding and removing thread members that were removed with #10023.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Jiralite Jiralite added this to the discord.js 14.17 milestone Oct 11, 2024
@Jiralite Jiralite requested a review from a team as a code owner October 11, 2024 13:51
@Jiralite Jiralite requested review from vladfrangu, iCrawl, kyranet and SpaceEEC and removed request for a team October 11, 2024 13:51
Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 11:55pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 11:55pm

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait for discord to :trollface: us with this at some point and support it

@Jiralite Jiralite requested a review from almeidx October 11, 2024 14:39
@Jiralite Jiralite force-pushed the refactor/deprecate-thread-member-reason branch from 43eb7fe to d2e74a4 Compare October 11, 2024 14:41
@Jiralite Jiralite force-pushed the refactor/deprecate-thread-member-reason branch from d2e74a4 to 654fe1f Compare October 11, 2024 23:55
@Jiralite Jiralite merged commit 72e0c99 into v14 Oct 11, 2024
8 checks passed
@Jiralite Jiralite deleted the refactor/deprecate-thread-member-reason branch October 11, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants