Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove extra traversing #10580

Merged
merged 2 commits into from
Oct 25, 2024
Merged

refactor: remove extra traversing #10580

merged 2 commits into from
Oct 25, 2024
+4 −7

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Some code was eventually making its way back to itself. The redundancy has been removed.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Jiralite Jiralite added this to the discord.js 15.0.0 milestone Oct 24, 2024
@Jiralite Jiralite requested a review from a team as a code owner October 24, 2024 23:47
@vercel Vercel
Copy link

vercel bot commented Oct 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 9:31am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 9:31am

didinele
didinele approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@didinele didinele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concerning.

almeidx
almeidx previously requested changes Oct 25, 2024
View reviewed changes
Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discord.js/packages/discord.js/src/managers/GuildScheduledEventManager.js

Line 178 in 435042e

this.guild.scheduledEvents._add(rawGuildScheduledEventData, options.cache),

@Jiralite Jiralite requested a review from almeidx October 25, 2024 09:36
@almeidx almeidx changed the title refactor: Remove extra traversing refactor: remove extra traversing Oct 25, 2024
@almeidx
Copy link
Member

almeidx commented Oct 25, 2024

😄

discord.js/.github/COMMIT_CONVENTION.md

Line 79 in 48a9c66

- don't capitalize the first letter

@kodiakhq kodiakhq bot merged commit b932b64 into main Oct 25, 2024
10 checks passed
@kodiakhq kodiakhq bot deleted the refactor/remove-extra-traverse branch October 25, 2024 09:39
Jiralite added a commit that referenced this pull request Oct 25, 2024
@Jiralite
refactor: remove extra traversing (#10580)
33533b7 
* refactor: remove extra traversion

* refactor(GuildScheduledEventManager): address fetch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx approved these changes

@didinele didinele didinele approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
packages:discord.js refactor semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js 15.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Jiralite @almeidx @vladfrangu @didinele