Base Emoji class for ReactionEmoji and renamed GuildEmoji classes #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpaceEEC
changed the title
SpaceEEC
force-pushed
the
animated_emoji
branch
from
a4b3b75 to
408a3ac
Compare
SpaceEEC
changed the title
vladfrangu
reviewed
Jan 9, 2018
src/stores/GuildEmojiStore.js
Outdated
| @@ -1,15 +1,15 @@ | |||
| const DataStore = require('./DataStore'); | |||
| const Emoji = require('../structures/Emoji'); | |||
| const GuildEmoji = require('../structures/GuildEmoji'); | |||
| const ReactionEmoji = require('../structures/ReactionEmoji'); | |||
|
|
|||
| /** | |||
| * Stores emojis. | |||
There was a problem hiding this comment.
This is a bit obscure.. Isn't there a store for the main client? If there is, this should state that it stores guild emojis (unless client uses a collection in which case :P)
vladfrangu
reviewed
Jan 9, 2018
SpaceEEC
force-pushed
the
animated_emoji
branch
from
12afcb8 to
3bc4e41
Compare
bdistin
approved these changes
Jan 15, 2018
vladfrangu
pushed a commit
to vladfrangu/discOwOd.js
that referenced
this pull request
Jan 18, 2018
…scordjs#2230) * feat: create base Emoji class for ReactionEmoji and new GuildEmoji * rename EmojiStore to GuildEmojiStore to account for the new class' name
vladfrangu
pushed a commit
to vladfrangu/discOwOd.js
that referenced
this pull request
Jan 18, 2018
…sses (discordjs#2230)" This reverts commit 97e1ca0.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Create new
Emojiclass as base forGuildEmojiandReactionEmojito avoid code duplicationSummary:
EmojitoGuildEmoji, refelects in StructuresEmojiclass to avoid code duplication betweenGuildEmojiandReactionEmojiGuildEmojiandReactionEmojiextend saidEmojiclassEmojiStoretoGuildEmojiStoreto stay consistent with the class' nameGuildEmojiTODO:
instanceofs and similar are correctSemantic versioning classification: