Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(User#locale) #2571

Merged
merged 1 commit into from
Jun 10, 2018
Merged

feat(User#locale) #2571

merged 1 commit into from
Jun 10, 2018

Conversation

kevinbioj
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Cover the totally new Discord API feature: the user's locale. The locale set on the user's client (desktop/mobile) will be sent through the User object to bots.
More information: discord/discord-api-docs#535

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@SpaceEEC
Copy link
Member

This seems to be more of an oauth feature than a bot feature.

It is restricted to GET /users/@me, which limits it for bots to only themselves when one explicitly fetches them with client.users.fetch('@me'). (Not received via gateway)

Also bots seem to always have en-US as language.

@xDimGG
Copy link
Contributor

xDimGG commented May 30, 2018

Basically what space said.

This feature is adding support for a property which is meant to be used with OAuth2 and since bots always have en-US (according to space) and this lib isn't looking to support user accounts (#2559) it wouldn't make much sense to have this property.

But, feel free to change my mind.

@kevinbioj
Copy link
Contributor Author

Eh you're right. There was a miscommunication on the original issue obviously. I thought bot accounts could get the locale, anyway.

To close 🔒

@kevinbioj kevinbioj closed this May 31, 2018
@devsnek
Copy link
Member

devsnek commented Jun 1, 2018

can we re-open this? rpc uses it downstream

@kevinbioj kevinbioj reopened this Jun 1, 2018
@kevinbioj
Copy link
Contributor Author

👌

@Lewdcario Lewdcario merged commit bce9a8a into discordjs:master Jun 10, 2018
SpaceEEC added a commit to discordjs/discord.js-typings that referenced this pull request Jun 15, 2018
1Computer1 pushed a commit to 1Computer1/discord.js that referenced this pull request Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants