Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Delete UserConnection structure #2758

Merged
merged 1 commit into from
Aug 17, 2018

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Aug 17, 2018

Please describe the changes this PR makes and why it should be merged:

With #2559, user-bot support was removed from discord.js, however, UserConnection (only used before that PR via User#fetchProfile, which returned an UserProfile instance, all of them for user-bots) remanied untouched. In a quick global search between all discordjs repositories, I could not find any other place using this class anymore.

This PR removes this class to complete the user-bot support removal by removing a class bot accounts cannot use.

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@SpaceEEC SpaceEEC merged commit 4999f67 into discordjs:master Aug 17, 2018
SpaceEEC added a commit that referenced this pull request Aug 17, 2018
@kyranet kyranet deleted the userconnection branch September 2, 2018 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants