fix(VoiceReceiver): delete opus encoder from map in stoppedSpeaking #3499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR fixes
VoiceReceiver
s failing to decode PCM data after the first silence of a user.The cause is that the relevant
OpusEncoder
got reused after being destroyed.It was destroyed here, but not removed from the map like it should.
discord.js/src/client/voice/receiver/VoiceReceiver.js
Lines 113 to 115 in 505df2e
After removing it from the map a new one was created in case the user starts speaking again and valid PCM data could be decoded.
This PR also fixes the documentation about the PCM format, it's actually
s16
and nots32
.Status
Semantic versioning classification: