Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/fix(GuildAuditLogs): handle new event types #3602

Merged
merged 5 commits into from
Feb 24, 2020
Merged

feat/fix(GuildAuditLogs): handle new event types #3602

merged 5 commits into from
Feb 24, 2020

Conversation

SpaceEEC
Copy link
Member

@SpaceEEC SpaceEEC commented Nov 28, 2019 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

This PR builds on top of #3584 handling the data of the new event types.

Integration was added to AuditLogTargetType, AuditLogEntryTarget and cached in the parent GuildAuditLogs object like webhooks.

The previously added event types were added to GuildAuditLogs.actionType to properly reflect the type of their action.

GuildAuditLogsEntry#extra now properly holds relevant data for the new types.

GuildAuditLogsEntry#target does no longer create a partial user with the id null for event types that do not provide a user id although targetting users (MEMBER_DISCONNECT, etc.)

Status

  • Code changes, except integrations, have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@RDambrosio016 RDambrosio016 mentioned this pull request Dec 21, 2019
Closed
@amishshah amishshah added this to the 12.0.0 milestone Jan 13, 2020
@monbrey monbrey mentioned this pull request Feb 1, 2020
Merged
5 tasks
@SpaceEEC SpaceEEC mentioned this pull request Feb 12, 2020
Closed
@iCrawl iCrawl merged commit a69ebbe into discordjs:master Feb 24, 2020
samsamson33 pushed a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
@SpaceEEC @samsamson33
feat/fix(GuildAuditLogs): handle new event types (discordjs#3602)
eea94ce 
* feat/fix(GuildAuditLogs): handle new event types

* fix(GuildAuditLogsEntry): coerce to numbers, simplify extra for deleted entities

* fix(GuildAuditLogsEntry): do not revert 'type' extra
samsamson33 added a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
@samsamson33
Revert "feat/fix(GuildAuditLogs): handle new event types (discordjs#3602
a038c3c 
)"

This reverts commit eea94ce.
@SpaceEEC SpaceEEC deleted the feat/audit_logs branch March 21, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpaceEEC @iCrawl @amishshah