Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Invites): add support for INVITE_CREATE and INVITE_DELETE. #3720

Merged
merged 6 commits into from
Jan 24, 2020
Merged

feat(Invites): add support for INVITE_CREATE and INVITE_DELETE. #3720

merged 6 commits into from
Jan 24, 2020

Conversation

RDambrosio016
Copy link
Contributor

@RDambrosio016 RDambrosio016 commented Jan 19, 2020 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:
this pr adds support for two new events, INVITE_CREATE and INVITE_DELETE, which are documented in discord/discord-api-docs#1309. it mostly answers #3668
Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

NotSugden
NotSugden reviewed Jan 19, 2020
View reviewed changes
NotSugden
NotSugden reviewed Jan 19, 2020
View reviewed changes
SpaceEEC
SpaceEEC requested changes Jan 19, 2020
View reviewed changes
Androz2091
Androz2091 approved these changes Jan 19, 2020
View reviewed changes
Copy link
Contributor

@Androz2091 Androz2091 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. It works perfectly!

@monbrey monbrey mentioned this pull request Jan 20, 2020
Merged
5 tasks
monbrey
monbrey requested changes Jan 21, 2020
View reviewed changes
@SpaceEEC SpaceEEC merged commit 929ff9c into discordjs:master Jan 24, 2020
@Khaaz Khaaz mentioned this pull request Feb 22, 2020
Merged
7 tasks
samsamson33 pushed a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
@RDambrosio016 @samsamson33
feat(Client): add support for INVITE_CREATE and INVITE_DELETE events (d…
5eef797 
…iscordjs#3720)

* Add support for new Invite events

* Merge typings for events

Co-Authored-By: Sugden <[email protected]>

* Add warning about requiring permissions

* Null check channel and guild

* fix: .guilds not .channels
samsamson33 added a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
@samsamson33
Revert "feat(Client): add support for INVITE_CREATE and INVITE_DELETE…
4853f1e 
… events (discordjs#3720)"

This reverts commit 5eef797.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotSugden NotSugden NotSugden left review comments

@monbrey monbrey monbrey requested changes

@amishshah amishshah amishshah approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@Androz2091 Androz2091 Androz2091 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RDambrosio016 @monbrey @amishshah @SpaceEEC @NotSugden @Androz2091