-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MessageReaction#remove and MESSAGE_REACTION_REMOVE_EMOJI #3723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jan 19, 2020
Co-Authored-By: matthewfripp <[email protected]>
amishshah
requested changes
Jan 20, 2020
SpaceEEC
requested changes
Jan 20, 2020
Co-Authored-By: SpaceEEC <[email protected]>
amishshah
approved these changes
Jan 23, 2020
monbrey
requested changes
Jan 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MessageReaction#remove()
is missing from typings
5 tasks
Fixed in |
SpaceEEC
approved these changes
Jan 25, 2020
7 tasks
samsamson33
pushed a commit
to samsamson33/discord.js
that referenced
this pull request
Feb 27, 2020
…moveEmoji (discordjs#3723) * Add support for MessageReaction#remove and MESSAGE_REACTION_REMOVE_EMOJI * Remove reaction from cache Co-Authored-By: matthewfripp <[email protected]> * fix: message may be partial * Clarify what the event entails * Document client in MessageReaction Co-Authored-By: SpaceEEC <[email protected]> * await the REST call * Add MessageReaction#remove to typings Co-authored-by: matthewfripp <[email protected]> Co-authored-by: SpaceEEC <[email protected]>
samsamson33
added a commit
to samsamson33/discord.js
that referenced
this pull request
Feb 27, 2020
…actionRemoveEmoji (discordjs#3723)" This reverts commit 9f4cb4c.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This pr adds support for the new event MESSAGE_REACTION_REMOVE_EMOJI documented in discord/discord-api-docs#1309, it adds a new method to
MessageReaction
to remove it (remove all occurences of an emoji reaction from a message). it adds another event which is triggered when a bot does this too.Status
Semantic versioning classification: