Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MessageReaction#remove and MESSAGE_REACTION_REMOVE_EMOJI #3723

Merged
merged 8 commits into from
Jan 25, 2020

Conversation

RDambrosio016
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This pr adds support for the new event MESSAGE_REACTION_REMOVE_EMOJI documented in discord/discord-api-docs#1309, it adds a new method to MessageReaction to remove it (remove all occurences of an emoji reaction from a message). it adds another event which is triggered when a bot does this too.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Copy link
Member

@monbrey monbrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MessageReaction#remove() is missing from typings

@RDambrosio016
Copy link
Contributor Author

MessageReaction#remove() is missing from typings

Fixed in ebefc90

@SpaceEEC SpaceEEC merged commit 030d263 into discordjs:master Jan 25, 2020
samsamson33 pushed a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
…moveEmoji (discordjs#3723)

* Add support for MessageReaction#remove and MESSAGE_REACTION_REMOVE_EMOJI

* Remove reaction from cache

Co-Authored-By: matthewfripp <[email protected]>

* fix: message may be partial

* Clarify what the event entails

* Document client in MessageReaction

Co-Authored-By: SpaceEEC <[email protected]>

* await the REST call

* Add MessageReaction#remove to typings

Co-authored-by: matthewfripp <[email protected]>
Co-authored-by: SpaceEEC <[email protected]>
samsamson33 added a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants