Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new MessageTypes #3812

Merged
merged 3 commits into from
Feb 22, 2020
Merged

add new MessageTypes #3812

merged 3 commits into from
Feb 22, 2020

Conversation

NotSugden
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
discord/discord-api-docs@ad3a26f Message Types 14 & 15 are now documented, so this PR adds them (as a note: type 13 isnt documented, but there is a PR open, seems be to expirimental discord/discord-api-docs#1265)

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the links to the discord-api-docs

@SpaceEEC SpaceEEC merged commit ef8acec into discordjs:master Feb 22, 2020
SpaceEEC pushed a commit that referenced this pull request Feb 22, 2020
* document types

* typings

* move comment
@NotSugden NotSugden deleted the patch-7 branch February 22, 2020 14:35
samsamson33 pushed a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
* document types

* typings

* move comment
samsamson33 added a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants