Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract class for Collect1D #1648

Closed
Tracked by #1769
Danbr4d opened this issue Aug 29, 2023 · 0 comments
Closed
Tracked by #1769

Abstract class for Collect1D #1648

Danbr4d opened this issue Aug 29, 2023 · 0 comments
Assignees
@Danbr4d
Labels
Scope: Generator Related to generator implementation, nodes etc. Type: Enhancement Enhancement for existing feature

Comments

@Danbr4d
Copy link
Contributor

Danbr4d commented Aug 29, 2023

We could make an abstract class AbstractCollect1DProcedureNode and have both Collect1DProcedureNode and IntegerCollect1DProcedureNode descend from it. This would allow IterateData1D to have a single sourceData_ pointer that could reference either type, depending on which concrete class it's pointing toward. This would simplify a bunch of the logic in the prepare and execute functions.
@Danbr4d Danbr4d added the Type: Enhancement Enhancement for existing feature label Aug 29, 2023
@trisyoungs trisyoungs added the Scope: Generator Related to generator implementation, nodes etc. label Sep 1, 2023
@trisyoungs trisyoungs mentioned this issue Jan 19, 2024
Closed
14 tasks
@Danbr4d Danbr4d closed this as completed Apr 23, 2024
@github-project-automation github-project-automation bot moved this to Complete in Overview Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Danbr4d Danbr4d

Labels
Scope: Generator Related to generator implementation, nodes etc. Type: Enhancement Enhancement for existing feature
Projects
Overview
Status: Complete
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trisyoungs @Danbr4d