Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Epic] Refactor Analysis Modules #1769

Closed
13 of 14 tasks
trisyoungs opened this issue Jan 19, 2024 · 3 comments
Closed
13 of 14 tasks

[Epic] Refactor Analysis Modules #1769

trisyoungs opened this issue Jan 19, 2024 · 3 comments
Labels
Epic An epic containing one or more steps / related issues Priority: Medium Indicates an Epic with medium priority

Comments

@trisyoungs
Copy link
Member

trisyoungs commented Jan 19, 2024 •
edited
Loading

Focus

Highlighted and described in #1747, this Epic encapsulates all necessary work related to moving our existing analysis modules from the old Procedure/ProcedureNode-based system onto a more developer-friendly footing.

Tasks (Modules)

  • Convert angle Module
  • Convert avgMol Module
  • Convert axisAngle Module
  • Convert dAngle Module
  • Convert histogramCN Module
  • Convert intraAngle Module
  • Convert intraDistance Module
  • Convert orientedSDF Module
  • Convert sdf Module
  • Convert siteRDF Module

Knock-on Effects

Once complete the following issues are potentially redundant.
@trisyoungs trisyoungs added Priority: Medium Indicates an Epic with medium priority Epic An epic containing one or more steps / related issues labels Jan 19, 2024
@jws-1 jws-1 mentioned this issue Jan 28, 2024
Merged
@jws-1 jws-1 mentioned this issue Feb 4, 2024
Merged
5 tasks
@jws-1 jws-1 mentioned this issue Feb 11, 2024
Merged
5 tasks
@jws-1
Copy link
Member

jws-1 commented Feb 18, 2024

avgMol doesn't actually utilise the Procedure framework - is there some other refactoring that you had in mind regarding it?

@trisyoungs
Copy link
Member Author

TBH it's probably due a refactor, but since it's not based off the Procedure stuff I think we can leave it be for now.

@trisyoungs
Copy link
Member Author

Closed by #1789 and #1795.

@github-project-automation github-project-automation bot moved this to Complete in Overview Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Epic An epic containing one or more steps / related issues Priority: Medium Indicates an Epic with medium priority
Projects
Overview
Status: Complete
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trisyoungs @jws-1