Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid std::list if possible #619

Closed
6 tasks done
trisyoungs opened this issue Mar 30, 2021 · 0 comments · Fixed by #970
Closed
6 tasks done

Avoid std::list if possible #619

trisyoungs opened this issue Mar 30, 2021 · 0 comments · Fixed by #970
Assignees
@IVlaD17

Comments

@trisyoungs
Copy link
Member

trisyoungs commented Mar 30, 2021 •
edited by IVlaD17
Loading

std::list is very useful as a container since it maintains references to objects on insertion / deletion (unlike std::vector) however it it has a larger footprint per item in the container, and does not store objects contiguously in memory. It should be replaced with other containers where possible to do so:

Current Uses

  • Data1DStore (as std::list<std::pair<Data1D, Data1DImportFileFormat>>)
  • Data2DStore (as std::list<std::pair<Data2D, Data2DImportFileFormat>>)
  • Data3DStore (as std::list<std::pair<Data3D, Data3DImportFileFormat>>)
  • CoreData (as std::list<MasterIntra>) - it appears all std::list usages have been replaced with std::vector
  • SpeciesAtom (as std::list<SpeciesAtom>) - it appears all std::list usages have been replaced with std::vector
  • Several GUI helper functions (combopopulator.h, tablewidgetupdater.h, treewidgetupdater.h) take std::list as data.
@trisyoungs trisyoungs mentioned this issue Mar 30, 2021
Merged
@IVlaD17 IVlaD17 self-assigned this Feb 9, 2022
IVlaD17 added a commit that referenced this issue Feb 9, 2022
@IVlaD17
#619:Replaced std::lists with std::vectors in the DataStore classes.
e36414d
IVlaD17 added a commit that referenced this issue Feb 10, 2022
@IVlaD17
#619: Replaced std::list with std::vector in the gui helper methods.
12b6612
@IVlaD17 IVlaD17 mentioned this issue Feb 10, 2022
Merged
IVlaD17 added a commit that referenced this issue Feb 10, 2022
@IVlaD17
#619:Replaced std::lists with std::vectors in the DataStore classes.
2c96957
IVlaD17 added a commit that referenced this issue Feb 10, 2022
@IVlaD17
#619: Replaced std::list with std::vector in the gui helper methods.
95abce8
IVlaD17 added a commit that referenced this issue Feb 15, 2022
@IVlaD17
#619: Attempt to fix compilation issues shown on the CI/CD
e1a5e23
IVlaD17 added a commit that referenced this issue Feb 16, 2022
@IVlaD17
#619: Updated the vectors to hold reference wrappers to pairs instead…
4f1c8be 
… of pairs.
IVlaD17 added a commit that referenced this issue Feb 16, 2022
@IVlaD17
#619: Replaced the reference_wrappers with shared_ptrs.
7022c9f
IVlaD17 added a commit that referenced this issue Feb 16, 2022
@IVlaD17
#619: Fixed formatting issues.
41ed76a
IVlaD17 added a commit that referenced this issue Feb 16, 2022
@IVlaD17
#619: Fixed formatting issues again.
b53b20f
IVlaD17 added a commit that referenced this issue Mar 7, 2022
@IVlaD17
#619: Fixed the segfaults (hopefully)
3b82a16
IVlaD17 added a commit that referenced this issue Mar 8, 2022
@IVlaD17
#619: Code tidy-ups according to Tristan's comments on the PR
ab64e66
IVlaD17 added a commit that referenced this issue Mar 8, 2022
@IVlaD17
#619: Fixed formatting problems
34ed26a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IVlaD17 IVlaD17

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace Lists with Vectors disorderedmaterials/dissolve
2 participants
@trisyoungs @IVlaD17