Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix benchmark data upload and nix integration #1951

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

trisyoungs
Copy link
Member

@trisyoungs trisyoungs commented Jun 27, 2024

Of course, following #1927 I broke the benchmark data upload because the path had changed.

This PR hopefully fixes that.

Also, this PR fixes the nix build!

Closes #1957

@trisyoungs trisyoungs changed the title build: Fix benchmark output file path build: Fix benchmark data upload and nix integration Jun 27, 2024
@RobBuchananCompPhys RobBuchananCompPhys merged commit 4d4fbe0 into develop Jul 5, 2024
10 checks passed
@RobBuchananCompPhys RobBuchananCompPhys deleted the 1927-tidy-benchmarks-followup branch July 5, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake preset configuration step fails - can't find benchmark pkg
2 participants