-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TheProtonApp.zip file structure #24
Comments
I'm not sure this is possible, I searched the electron-builder documentation and issues and I did not find that option, or anybody talking to something related to that. I made an issue asking directly if it is even possible on the electron-builder repo. But in the meantime I guess we have to keep it like it is. |
OK I got a response to the issue, and they said that this is not supported yet, but they where going to work on this in the near future since it is an easy implementation and others have asked for this feature already. |
OK so for now I added the batch file (TheProtonApp.cmd) workaround so the file structure currently looks like this:
So the rest of the folders from the screenshot you provided at the top (config, logs, templates, etc), need to be put on the Please let me know what do you think of this approach. |
Does the symlinks work on Windows? |
I think they do: https://msdn.microsoft.com/en-us/library/windows/desktop/aa365680(v=vs.85).aspx I still need to implement and test to make sure it behaves as expected |
Why not have ./config (and all other folders from the screenshot) like I put in screenshot and then in the APP code you'll point to these folders with relative paths similar with ../../.. (how many .. parent relatives are necessary). And of course you'll not hard code in JS code ../../.. you'll have some kind of configuration CONFIG FOLDER which will come from a development.js / production.js where you'll configure all paths (you did something similar in the-app) check here - theapp-template Also check the theapp-template/TheApp from here https://github.com/distributev/the-app - you implemented this and it's good. theapp-template/TheApp structure keeps a "template" with all the files / folders which are "static" (not the built code) and this is like a boiler-plate for the package-application. Do you remember theapp-template/TheApp packaging idea? Do the same now. |
When opening the zip file the user should not see any file/folder which is not directly related with the
TheProtonApp.exe functionality (all the electron/node runtime files / folders / resources i.e. node.dll should be moved under the _internal folder)
The text was updated successfully, but these errors were encountered: