Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commit hook and deleting file #110

Closed
benneti opened this issue Feb 3, 2021 · 2 comments
Closed

commit hook and deleting file #110

benneti opened this issue Feb 3, 2021 · 2 comments

Comments

@benneti
Copy link
Contributor

benneti commented Feb 3, 2021

Describe the bug
I tried to delete a file but then git commit failed.
As I do not now the reason exactly I simply moved .git/hooks temporarily to another place, then I was able to add the commit message.

To Reproduce
Steps to reproduce the behavior:

  1. Delete a file
  2. commit
  3. try to "git commit -m asdf"
  4. See error

Expected behavior
Git commit hook should not interfere with usual git actions.
@nrdxp
Copy link
Collaborator

nrdxp commented Feb 3, 2021

This should have been fixed a few days ago with e7d9abf

Have you updated since then?

@benneti
Copy link
Contributor Author

benneti commented Feb 3, 2021

ah sorry indeed, did the merge with master after i realized this.
Thanks for the heads up

@benneti benneti closed this as completed Feb 3, 2021
Pacman99 pushed a commit that referenced this issue Feb 23, 2022
@linyinfeng @Pacman99
fix: fix broken overlays on nixos-unstable, close #110
88a3498 
After nixpkgs pr #140284, attrset outputs of functions of type
`anything` are now processed as modules.

This is not the expected behavior for overlays, devshell modules, and
nixos tests. Use new option types instead of `anything`, fixing this
issue.
Pacman99 pushed a commit that referenced this issue Feb 26, 2022
@linyinfeng
fix: fix broken overlays on nixos-unstable, close #110
0afec1b 
After nixpkgs pr #140284, attrset outputs of functions of type
`anything` are now processed as modules.

This is not the expected behavior for overlays, devshell modules, and
nixos tests. Use new option types instead of `anything`, fixing this
issue.
Pacman99 pushed a commit that referenced this issue Feb 26, 2022
@bors @linyinfeng
Merge #112
dfe68a1 
112: Fix broken overlays on nixos-unstable, close #110 r=blaggacao a=linyinfeng

After <NixOS/nixpkgs#140284>, attrset outputs of functions of type `anything` are now processed as modules.
    
This is not the expected behavior for overlays, devshell modules, and nixos tests. Use new option types instead of `anything`, fixing this issue.

Co-authored-by: Lin Yinfeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benneti @nrdxp