-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
host: add deault implementation for system.build.isoImage target (per… #102
Conversation
a5ef9c9
to
210c330
Compare
preview idea for possible sd + netboot support: blaggacao#1 |
c51eb30
to
00bb079
Compare
This looks great. Anything else you want to implement, or is it ready for merge? |
This is ready for merge, going forward you might put a close eye on what would be necessary here: https://github.com/nrdxp/nixflk/pull/102/files#diff-9e2394d5d965447692e8b09d0235b8fdd8426071c2537d0e4a7e4786d9fcf97eR32-R33 Please also build on your machine to check if everything works (it worked over here). I'm still fighting with sd-images for similar reasons (option overrides) on blaggacao#1 (while netboot seems good). I might open another PR with netboot support, soonish though. |
I'll give it a test drive and see if everything works out. If so I'll go ahead and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically just wondering if we can break out the logic in lib/default.nix instead of clutter the head of hosts/default.nix. Other than that, everything seems to work wonderfully.
For future reference / inspiration: https://github.com/nix-community/nixos-generators, specifically: nix-community/nixos-generators#85 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, also please update the README.md to reflect the new changes.
Can you review again:
|
00bb079
to
d661432
Compare
d661432
to
8e365a3
Compare
8e365a3
to
8cb82a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sent a PR with some small style fixups to keep the line limit under control. Other than that, this looks ready to merge!
… host)
This is a more generic implementation to ISO builds, similar to what nixpkgs/flake.nix does with
lib.nixosSystem
for VMs.In a follow up PR, I'll implement netboot and sd card flashing (in principle)
as prototyped here: numtide/flake-utils@d1ff2f0
Looks promising:
The wireless conflict (2nd commit) comes from the installation device profile
EDIT: I fixed
flk iso NixOS
in latest force-push