[Merged by Bors] - treewide cleanups and refactoring for initial tests #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take inspiration from nixpkgs/lib.
Lay the groundwork for easily testing profiles and modules via `pkgs.nixosTest` and the new `testModule`.
nrdxp
changed the title
nrdxp
changed the title
|
bors ping |
|
pong |
|
bors try |
tryConfiguration problem: |
|
bors try |
tryBuild succeeded: |
Pacman99
approved these changes
Mar 13, 2021
Pacman99
reviewed
Mar 13, 2021
| networking.wireless.iwd.enable = lib.mkForce false; | ||
| }) | ||
| ]; | ||
| })).config; |
There was a problem hiding this comment.
Unrelated, I can submit a seperate PR for this. It turns out home-manager.useUserPackages has to be set to false with home-manager only configurations, so I added a hmConfig for hm-only configs.
hmConfig = (nixosSystem
(args // {
modules = modules ++ [
({ ... }: {
home-manager.useUserPackages = mkForce false;
})
];
})).config;
Test whether a system containing all available profiles reaches a successfully running state with no failed systemd services.
Reloading on every Nix file change is a bit too aggressive, causing unnecessary reloads.
nrdxp
changed the title
blaggacao
approved these changes
Mar 13, 2021
Add sophistication to the version generation function, and use it automatically on package sources pulled from pkgs/flake.nix. Also remove it from lib, as it is no longer general purpose.
Also add a README.md for tests.
|
bors r+ |
|
👎 Rejected by too few up-to-date approved reviews (some of the PR reviews are stale) |
Pacman99
approved these changes
Mar 14, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2021
- [x] refactor lib into separate files, similar to NixOS/nixpkgs/lib. - [x] refactor ci to automatically generate derivations from flake outputs - [x] remove cluttered indirection statements throughout the codebase - [x] refactor hosts to allow for upcoming integration tests - [x] improve ambiguity in the existing docs - [x] add [BORS](https://bors.tech) support - [x] add initial integration test - [x] write tests documentation - [x] test lib - [x] improve version string generation, and do so automatically for pkgs/flake.nix sources Clean up the codebase as best we can in preparation for #152 and add tests. From now on, all PRs will be merged with BORS.
|
Pull request successfully merged into core. Build succeeded: |
bors
bot
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the codebase as best we can in preparation for #152 and add tests. From now on, all PRs will be merged with BORS.