Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Haskell overlay #330

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Fix: Haskell overlay #330

merged 1 commit into from
Jun 25, 2021

Conversation

GTrunSec
Copy link
Contributor

using lib.composeExtensions for packageOverrides is more idiomatic.
Fixes: #325 (review)
such as

 python3 = pkgs.python3.override (old: {
   5 │ │ packageOverrides =
   4 │ │ │ pkgs.lib.composeExtensions
   3 │ │ │ │ (old.packageOverrides or (_: _: { }))
   2 │ │ │ │ packageOverrides;
   1 │ });

@blaggacao
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 25, 2021

👎 Rejected by too few approved reviews

blaggacao
blaggacao approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@blaggacao blaggacao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for researching this!

@blaggacao
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 25, 2021

Build succeeded:

@bors bors bot merged commit 741e8fd into divnix:develop Jun 25, 2021
@GTrunSec GTrunSec deleted the haskell-overlay branch June 25, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blaggacao blaggacao blaggacao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GTrunSec @blaggacao