Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bud and misleading onboarding docs #477

Merged
merged 5 commits into from
Jul 10, 2022
Merged

Conversation

montchr
Copy link
Collaborator

@montchr montchr commented Jul 9, 2022

This has been planned for some time.

It seems necessary to do so now because after updating inputs to track
NixOS 22.05 channels and releases, checks fail unexpectedly, with the
traces leading back to bud. Disabling its modules allows checks to
run successfully.

Rather than figuring out what's going wrong with bud, it seems more
appropriate to remove it as planned.

Because this is closely related to updating Digga/Devos to support 22.05,
I've set #476 as a base branch.

Many many people have complained about the misleading documentation.
Rather than continuing the path of "we need to fix this", we can reduce
the harmful effects of the inaccurate docs by removing them all
together.

Since much of the confusion in the "getting started" docs came from
bud-specific instructions, and bud is being removed, removing the
inaccurate docs also seems like it can be a kick towards replacing them.

Also:

  • The NixOS manual is the canonical guide to installation. We don't need
    to repeat its instructions.
  • The numerous references to networking configuration don't have a place
    within Digga -- I'm assuming these are bud-specific things which are
    no longer relevant with bud gone.

fixes #418

montchr added 5 commits July 9, 2022 16:24
This has been planned for some time.

It seems necessary to do so now because after updating inputs to track
NixOS 22.05 channels and releases, checks fail unexpectedly, with the
traces leading back to `bud`. Disabling its modules allows checks to
run successfully.

Rather than figuring out what's going wrong with `bud`, it seems more
appropriate to remove it as planned.
Many many people have complained about the misleading documentation.
Rather than continuing the path of "we need to fix this", we can reduce
the harmful effects of the inaccurate docs by removing them all
together.

Since much of the confusion in the "getting started" docs came from
`bud`-specific instructions, and `bud` is being removed, removing the
inaccurate docs also seems like it can be a kick towards replacing them.

Also:

- The NixOS manual is the canonical guide to installation. We don't need
to repeat its instructions.
- The numerous references to networking configuration don't have a place
within Digga -- I'm assuming these are `bud`-specific things which are
no longer relevant with `bud` gone.
@montchr montchr requested review from Pacman99, blaggacao and nrdxp July 9, 2022 20:41
@montchr montchr changed the title remove bud + trash misleading documentation remove bud and misleading onboarding docs Jul 9, 2022
@montchr montchr added this to the Release v0.12.0 milestone Jul 9, 2022
@montchr montchr self-assigned this Jul 9, 2022
Copy link
Collaborator

@nrdxp nrdxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @blaggacao correct me if I'm wrong, but you probably don't have time maintain bud atm, so removing it is probably the right move at this point.

Copy link
Member

@Pacman99 Pacman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM bud has been on the chopping block for long enough

@montchr montchr merged commit 8d50be0 into update-inputs-22.05 Jul 10, 2022
@montchr montchr deleted the remove-bud branch July 10, 2022 22:09
montchr added a commit that referenced this pull request Jul 10, 2022
support nixos 22.05 + remove bud and misleading onboarding docs (via #477)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants