Don't evaluate overlays on master #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
master is only used in the context of `pkgs/override.nix` and `unstableModulesPath` and only within `./hosts` Since overlays exists that are incompatible between nixos and master at evaluation time (sic!), this together with divnix#77 avoids evaluating overlays against master all together.
blaggacao
pushed a commit
to blaggacao/flake-utils
that referenced
this pull request
Jan 11, 2021
|
I'm gonna have to test this, as I think it might break my qutebrowser overlay. |
|
I was thinking, if an overlay for a master package is needed, could this be conceptualized as a It would thinks easier, and wouldn't incommode too much? |
|
This doesn't seem to break anything. I'll go ahead an merge. I still want a better interface to pulling unstable overrides, but we can deal with that in a separate issue/pr. |
blaggacao
pushed a commit
to blaggacao/devos
that referenced
this pull request
Jul 6, 2021
Don't evaluate overlays on master
Pacman99
pushed a commit
that referenced
this pull request
Feb 23, 2022
also produce more cach hits using nixpkgs/release 21.05 fix: #78
Pacman99
pushed a commit
that referenced
this pull request
Feb 26, 2022
also produce more cach hits using nixpkgs/release 21.05 fix: #78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master is only used in the context of
pkgs/override.nixand
unstableModulesPathand only within
./hostsSince overlays exists that are incompatible between nixos and master
at evaluation time (sic!), this together with #77 avoids evaluating
overlays against master all together.
Proposal to
fix #76