MacOS support #123
Merged
MacOS support #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @carlba Can you update the documentation about the user part so other people can benefit from it as well? Thanks! |
|
Is this text sufficient? |
|
@carlba Fine by me! Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Provides MacOS support for the role. The brew service system works a bit different than most other linux/bsd service system in that it is only meant to be run as your local user account. I looked into creating a telegraf user and running the service as that but that doesn't seem inline with brew service best practices. On MacOs it is therefore required to specify a
telegraf_mac_userwhich should be your main user account.I also added role_name to the role meta since this is nowadays required to get the role to present correctly on Ansible Galaxy.
Type of change
Feature Pull Request