Add Windows feature of upgrade agents #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for the great solution, it saved me a huge headache in the first place. I would appreciate a thorough review as I am just dabbling with Ansible.
The molecule tests run successfully for me.
Description of PR
This PR improves the Windows installation by getting rid of the flag file and checking if the service is in place. Also it will compare the version of the desired installation and the current version of the machine. If it does match, it will leave the installation in peace, otherwise it will update the system. The change also contains log rotation for the Windows machines, which was unavaiable at the time of the telegraf version 1.10
Type of change
Feature Pull Request
Fixes an issue