update the README with the latest v0.13 - v1.1 agent settings #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! And keep the PR's coming if you think changes are needed to make the role(s) better. 👍 |
aarnaud
pushed a commit
to aarnaud/ansible-telegraf
that referenced
this pull request
Oct 24, 2017
…f-v1.1-settings update the README with the latest v0.13 - v1.1 agent settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some notes:
precisionis now missing, all the other settings are now configurable** I was not sure what default I'ld set (the best would probably be to omit setting it, if not set by the user)
Update: Could we 'release' a role version/tag (0.6.0 ?) 👍
ps: Seems plenty of other features were added in other config parts, like
fieldpass,fielddropin https://github.com/influxdata/telegraf/blob/master/docs/CONFIGURATION.md#processor-configuration.For now I can live with a basic config, but I am definitely considering my idea of supporting to deploy a (fully) custom telegraf.conf (template) , so there's no need to always keep updating the role with the latest new config features/settings