Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for extra win_perf_counters and prevent python u'' strings #76

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

jdivy
Copy link
Contributor

@jdivy jdivy commented Dec 13, 2018

Description of PR

  • Fixes an issue where python renders a list of counters as [u'CounterA', u'CounterB'] in telegraf config
  • Adds support for including win_perf_counters as 'extra' plugins

Type of change

Feature Pull Request
Bugfix Pull Request

Fixes an issue

  • Fixes an issue where python renders a list of counters as [u'CounterA', u'CounterB'] in telegraf config

@jdivy
Copy link
Contributor Author

jdivy commented Dec 13, 2018

Test failure seems unrelated to my changes (failed to install Debian package 1.9.0-1)

@dj-wasabi
Copy link
Owner

Hi @jdivy

No worries, it seems to relate to a version that isn't available anymore. I'll create a PR with a minute or 2 and once that is merged, I'll merge this PR.

@dj-wasabi dj-wasabi merged commit a4d3eb2 into dj-wasabi:master Dec 13, 2018
@dj-wasabi
Copy link
Owner

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants