Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: start testing Django 4.1 and Django main branch #85

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

kevinmarsh
Copy link
Contributor

Description

Figured before tackling #84 I thought it'd be worth running the test suite over Django 4.1 (and as a bonus over the main Django branch)

  • renames the unit-tests-dj4 job to unit-tests-future-versions, with the intent being that these are fine to fail since this package doesn't officially support them yet, however it's a good early indicator if this stops being compatible with an upcoming version of Django. I moved Django 4.0 up into the main unit-tests matrix since this package works fine on 4.0
  • Stop running GH action matrix over unsupported versions (eg. Django 2.2 doesn't need to be run against Python 3.10 since it's not actually supported)
  • Add Django 4.1 and main branch to tox but ignore their failures, no point forcing contributors to make their feature/bug work on unsupported versions (or once these are passing we could consider not ignoring them)

Related resources

Screenshot of tox output

You can see that tox failed for Django 4.1 and main branch

2022-09-09_10-54

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #85 (374bc71) into master (e7eee39) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #85   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files           9        9           
  Lines         541      541           
  Branches      121      121           
=======================================
  Hits          539      539           
  Misses          1        1           
  Partials        1        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@marksweb
Copy link
Member

marksweb commented Sep 9, 2022

@kevinmarsh Thank you for this.

I'd also be happy for us to drop django<3.2, although there's no harm keeping the tests running for now.

@marksweb
Copy link
Member

marksweb commented Sep 9, 2022

@kevinmarsh Also, just looking at options for those future tests and it looks like there's a continue-on-error attribute for steps which might stop them getting flagged as failing.

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepscontinue-on-error

@kevinmarsh kevinmarsh force-pushed the feature/test-on-django-41 branch from c43248d to 374bc71 Compare September 9, 2022 23:05
@kevinmarsh
Copy link
Contributor Author

@marksweb just pushed the continue-on-error: true seemed to work as expected, it shows the action was "successful" so you have to go into the actual action to see the failing test. But think that's fine for this use case

drop django<3.2

Would make sense to align with supported Django versions, maybe do this after #84 is fixed and can just change supported versions to 3.2-4.1

@marksweb
Copy link
Member

marksweb commented Sep 9, 2022

@kevinmarsh Yeah, I'm happy with that! 👍

@marksweb marksweb merged commit 505d6ba into django-cms:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants