Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using ProfilingPanel as non last panel #1299

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

noamkush
Copy link
Contributor

@noamkush noamkush commented Jul 9, 2020

The profiling panel profiles process_request so that's always the root function, but if it's not the last panel, it might have callers. As a result, the panel won't work unless it's last. Since we know what's the root we can use that instead of searching for it.

Fixes #1208

Base automatically changed from master to main February 11, 2021 15:01
@auvipy auvipy requested a review from jdufresne February 11, 2021 15:57
Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we update the tests or verify the changes with proper test cases?

@noamkush
Copy link
Contributor Author

Well, this panel is already covered by tests and I'm not sure there's anything new to test for.

@auvipy auvipy closed this Oct 26, 2021
@auvipy auvipy reopened this Oct 26, 2021
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #1299 (1187365) into main (7b9a488) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1299      +/-   ##
==========================================
+ Coverage   87.78%   87.97%   +0.19%     
==========================================
  Files          29       35       +6     
  Lines        1555     2328     +773     
  Branches      218      414     +196     
==========================================
+ Hits         1365     2048     +683     
- Misses        140      201      +61     
- Partials       50       79      +29     
Impacted Files Coverage Δ
debug_toolbar/panels/profiling.py 88.54% <100.00%> (-2.53%) ⬇️
debug_toolbar/panels/history/panel.py 89.70% <0.00%> (-5.65%) ⬇️
debug_toolbar/panels/history/views.py 95.34% <0.00%> (-4.66%) ⬇️
debug_toolbar/panels/cache.py 80.80% <0.00%> (-2.78%) ⬇️
debug_toolbar/apps.py 90.66% <0.00%> (-0.45%) ⬇️
debug_toolbar/decorators.py 100.00% <0.00%> (ø)
debug_toolbar/panels/request.py 100.00% <0.00%> (ø)
debug_toolbar/panels/sql/__init__.py 100.00% <0.00%> (ø)
debug_toolbar/panels/history/__init__.py 100.00% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b9a488...1187365. Read the comment docs.

@auvipy
Copy link
Contributor

auvipy commented Oct 26, 2021

lets see what the new CI tell

@auvipy auvipy merged commit 8633926 into django-commons:main Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProfilingPanel info not collected
2 participants