Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations for a bunch of languages. #1525

Merged
merged 1 commit into from
Dec 4, 2021
Merged

Update translations for a bunch of languages. #1525

merged 1 commit into from
Dec 4, 2021

Conversation

tim-schilling
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #1525 (488d305) into main (6808825) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1525      +/-   ##
==========================================
- Coverage   85.87%   85.71%   -0.16%     
==========================================
  Files          35       35              
  Lines        1883     1883              
  Branches      313      313              
==========================================
- Hits         1617     1614       -3     
- Misses        187      190       +3     
  Partials       79       79              
Impacted Files Coverage Δ
debug_toolbar/panels/profiling.py 85.41% <0.00%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6808825...488d305. Read the comment docs.

@matthiask
Copy link
Member

matthiask commented Nov 5, 2021

The german translations for database transaction isolation levels are not exactly understandable (to me). I submitted new translations on Transifex and reviewed a few strings.

@tim-schilling
Copy link
Member Author

@matthiask I'm not seeing the adjustments in transifex.

@tim-schilling
Copy link
Member Author

@matthiask it looks like you submitted English strings for the four transaction strings for the German language. Is that correct?

@matthiask
Copy link
Member

@matthiask it looks like you submitted English strings for the four transaction strings for the German language. Is that correct?

Yes. It seemed to me that even german blog posts prefer the english terms for the transaction isolation levels. I didn't consult any textbooks (because I do not have any). But searching google and some other sites didn't help with finding good and well-known translations.

@tim-schilling
Copy link
Member Author

tim-schilling commented Nov 13, 2021 via email

@tim-schilling
Copy link
Member Author

3 weeks later...

@tim-schilling tim-schilling merged commit 488d305 into django-commons:main Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants